Skip to content

feat: remove scene update deletions to test #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aneuwald-ctw
Copy link

As commented on issue #111, I tested OSI converter with not scene update deletions and I found a significant improvement of performance with no change on the visualization. Could youn guys validate it?

Obs.: This PR was not created with intention of merge, more to share modifications that could potentially improve performance.

@thomassedlmayer
Copy link
Collaborator

As discussed in #111 removing the deletion code is not possible due to the delta-based rendering of Lichtblick in combination with the stateless interface of OSI. For stateless interfaces like OSI, extensions always have to implement their own logic to delete objects that disappear from one frame to the next as long as this is not supported natively by Lichtblick.

Though, in #113 I removed and fixed the buggy code that adds lots of unnecessary deletions in every time step.

@jdsika I think we can close this PR. @aneuwald-ctw Thanks again for the hint to the bug.

@jdsika
Copy link
Contributor

jdsika commented Jul 30, 2025

Thank you for helping with the performance improvements!

@jdsika jdsika closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants