Skip to content

Revert "Add frame transform between ego bb and ego vehicle rear axis" #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jdsika
Copy link
Contributor

@jdsika jdsika commented Aug 4, 2025

Reverts #105

Thinking about it:

  • If an extension defines a frame, then this extension shall be responsible to define the transform to root as well
  • If I receive data which is attached to a frame then I shall only be able to display it with the transform from the plugin which is responsible for the data
  • The framework offers the feature to define Frames by (unique?) ID and to publish the respective transforms. Therefore the framework needs to define the rules for this feature. e.gf. enforce uniqueness, or error on missing transform, etc
  • It should be possible to recognize as framework which frame is identical to another frame regardless of the frame ID:
    • the quaternion should be the same
    • the identity might be valid for a specific time frame and change dynamically

@jdsika jdsika added bug Something isn't working cleanup Dead code, old dependencies, etc labels Aug 4, 2025
@jdsika jdsika added this to the v0.0.7 milestone Aug 4, 2025
@jdsika jdsika requested a review from rmessaou August 4, 2025 09:47
@jdsika jdsika merged commit ade792c into main Aug 5, 2025
1 check passed
@jdsika jdsika deleted the revert-105-add_frame_transform_between_bb_and_rear_axis branch August 5, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup Dead code, old dependencies, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants