This repository was archived by the owner on Jan 12, 2021. It is now read-only.
Fix --config handling and allow --append-config#94
Closed
thejcannon wants to merge 1 commit intolife4:masterfrom
thejcannon:cmd-config
Closed
Fix --config handling and allow --append-config#94thejcannon wants to merge 1 commit intolife4:masterfrom thejcannon:cmd-config
thejcannon wants to merge 1 commit intolife4:masterfrom
thejcannon:cmd-config
Conversation
Contributor
Author
|
@orsinium this is good to be reviewed |
Contributor
|
I tested the |
orsinium
reviewed
Jan 11, 2021
|
|
||
|
|
||
| def get_installed(app) -> Iterator[Dict[str, Any]]: | ||
| def get_installed(app, argv=[]) -> Iterator[Dict[str, Any]]: |
Member
There was a problem hiding this comment.
Please, don't use mutable default arguments for functions.
Member
|
Thank you for your contribution! Sorry for postponing the review of the PR. I'm still not sure what PR does, how it fixes the issue. Probably, I should try to debug it myself as well. |
Contributor
|
W/o this patch, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my testing, passing --config ./file.toml wasn't being handled correctly.
Debugging it, it looks like parse_preliminary_options in flake8 strips out these options, so by the time we get to it in parse_configuration_and_cli they are nowhere to be found in argv.