-
Notifications
You must be signed in to change notification settings - Fork 78
LPD-60729 Update project-templates to fix project templates versioning issue #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
drewbrokke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kyle-miho you'll also need to update the expected Workspace version in the InitCommandTest. You should be able to find examples of this in the Git history where we update the Project Templates version.
|
@drewbrokke We didnt update the workspace version though? only project templates how will we know what is expected? i saw other tickets where we update project templates but dont update the workspace version, for example LPD-44518 |
|
@kyle-miho a Workspace update is not required when we update Project Templates. It's actually the other way around - we want to update Project Templates after we update Workspace. |
|
If the workspace version changed at all between the last release and now, you'll need to update the expected version here. If all the tests pass then no change is needed. |
|
@drewbrokke no change should be needed to the workspace version, InitCommandTest passed |
|
Hey @kyle-miho just double-checking - the ticket numbers on the PR branch and the commits do not match. Which is the correct one? Can you please update or re-send with the correct ticket number for both? |
|
@kyle-miho I see that |
|
@drewbrokke |
78262da to
18d473c
Compare
|
@kyle-miho you're correct, I made a mistake somewhere in my local branch while checking. That's my bad! This looks good to go! 🚀 |
Related to: liferay-devtools/liferay-portal#591
DO NOT MERGE until project templates 6.0.10 is published