Skip to content

Conversation

@kyle-miho
Copy link
Member

@kyle-miho kyle-miho commented Sep 19, 2025

Related to: liferay-devtools/liferay-portal#591

DO NOT MERGE until project templates 6.0.10 is published

Copy link
Member

@drewbrokke drewbrokke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyle-miho you'll also need to update the expected Workspace version in the InitCommandTest. You should be able to find examples of this in the Git history where we update the Project Templates version.

@kyle-miho
Copy link
Member Author

kyle-miho commented Oct 8, 2025

@drewbrokke We didnt update the workspace version though? only project templates how will we know what is expected? i saw other tickets where we update project templates but dont update the workspace version, for example LPD-44518

@drewbrokke
Copy link
Member

@kyle-miho a Workspace update is not required when we update Project Templates. It's actually the other way around - we want to update Project Templates after we update Workspace.

@drewbrokke
Copy link
Member

If the workspace version changed at all between the last release and now, you'll need to update the expected version here. If all the tests pass then no change is needed.

@kyle-miho
Copy link
Member Author

@drewbrokke no change should be needed to the workspace version, InitCommandTest passed

@drewbrokke
Copy link
Member

Hey @kyle-miho just double-checking - the ticket numbers on the PR branch and the commits do not match. Which is the correct one? Can you please update or re-send with the correct ticket number for both?

@drewbrokke
Copy link
Member

@kyle-miho I see that 6.0.10 is published and will generate a workspace with version 14.0.0, so an expected value update is required. Interesting that the test passed in that case, but there is a mismatch.

@kyle-miho kyle-miho changed the title LPD-55390 Update project-templates to fix project templates versioning issue LPD-60729 Update project-templates to fix project templates versioning issue Nov 10, 2025
@kyle-miho
Copy link
Member Author

@drewbrokke
_GRADLE_PLUGINS_WORKSPACE_VERSION is 14.0.0 so shouldnt it not be suprising that it is passing?

@drewbrokke
Copy link
Member

@kyle-miho you're correct, I made a mistake somewhere in my local branch while checking. That's my bad! This looks good to go! 🚀

@drewbrokke drewbrokke merged commit 7098b83 into liferay:master Dec 17, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants