LPD-24481 NoSuchFileException error if blade init is used in a sub-directory of a workspace #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-chu
commented
Dec 10, 2025
| WorkspaceProvider workspaceProvider = bladeCLI.getWorkspaceProvider(baseDir); | ||
|
|
||
| if (workspaceProvider != null) { | ||
| if ((workspaceProvider != null) || bladeCLI.isInWorkspace(baseDir)) { |
Member
Author
There was a problem hiding this comment.
I'm not sure if this is the best place to put this check. I put it here to take advantage of the fact that the error was already being displayed here. However, I also considered the possibility of checking this earlier (as early as just after the destDir.exists() check in L105).
What do you think would be a better approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-24481