LPD-24481 NoSuchFileException error if blade init is used in a sub-directory of a workspace #372
+100
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbrokke
requested changes
Dec 16, 2025
drewbrokke
requested changes
Dec 18, 2025
Member
drewbrokke
left a comment
drewbrokke
left a comment
There was a problem hiding this comment.
@anthony-chu overall looking good, just a couple comments here.
| BladeTestResults bladeTestResults = TestUtil.runBlade( | ||
| baseDir, _extensionsDir, false, args2.toArray(new String[0])); | ||
|
|
||
| File workspaceDir2 = new File(baseDir.getPath() + File.separator + workspaceName2); |
Member
There was a problem hiding this comment.
I'm a bit confused about the relationship between the workspaceName parameter, workspaceName1 var, and workspaceName2 var. Is there a way we can make this a little clearer?
| bladeTestResults.getErrors( | ||
| ).contains( | ||
| "blade does not support initializing a workspace inside of another workspace." | ||
| )); |
Member
There was a problem hiding this comment.
SF: let's avoid chaining here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-24481