fiat: add support for using Coinbase to fetch hourly/daily prices #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
reviewed
May 2, 2025
fiat/coinbase_api.go
Outdated
| // ... | ||
| // ] | ||
| // | ||
| // Field meanings (per Coinbase docs): |
There was a problem hiding this comment.
should we provide a link to the docs here?
hieblmi
reviewed
May 2, 2025
fiat/coinbase_api.go
Outdated
| return io.ReadAll(resp.Body) | ||
| } | ||
|
|
||
| // paarseCoinbaseData parses the JSON response from Coinbase's candles endpoint. |
|
|
||
| prices := make([]*Price, 0, len(raw)) | ||
| for _, c := range raw { | ||
| if len(c) < 5 { |
There was a problem hiding this comment.
should this be != 5, or are there only cases with less than 5?
Member
Author
There was a problem hiding this comment.
Yeah good point. According to their docs: "Historical rate data may be incomplete. No data is published for intervals where there are no ticks.", so i'd say we should allow for rows where the data is "inclomplete" ie. likely empty. It's hard to say if they'd change their API's output in a non-backward compatible way, but I think it's safe to expect that they'd like introduce any breaking changes under a separate url path, eg. /v2/ etc. Added a comment clarifying incompleteness.
bhandras
force-pushed
the
coinbase-fiat-api
branch
from
fa14cb4 to
62634b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add Coinbase to the existing fiat sources.
Pull Request Checklist
MinLndVersionif your PR uses new RPC methods or fields oflnd.