Skip to content

mod+itest: make custom channel itest flakes less annoying #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

Conversation

guggero
Copy link
Member

@guggero guggero commented May 7, 2025

Runs the litd/terminal only itests separately from the custom channel itests, so flakes can be seen more clearly and ignored if not relevant.

@guggero guggero requested a review from ellemouton May 7, 2025 13:03
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thank you!

@guggero guggero requested a review from ViktorTigerstrom May 7, 2025 14:53
Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks, LGTM code wise 🚀🔥!

Though, I think we need to adjust the "Required Status Checks" before merging this, so that it reflects the new CI jobs. Currently we still get extra pending CI "duplicate jobs":

integration test (bbolt, dbbackend=bbolt)
integration test (postgres, dbbackend=postgres)
integration test (sqlite, dbbackend=sqlite)

As pending checks in the CI job list, as the required checks don't reflect the new updates. I think I lack the required permissions to change that though, so maybe you could do that before merging this @guggero :)?

@ViktorTigerstrom ViktorTigerstrom added the no-changelog This PR is does not require a release notes entry label May 7, 2025
@guggero
Copy link
Member Author

guggero commented May 7, 2025

@ViktorTigerstrom yes, that's correct. I'll need to update them. But only jobs on master can be chosen, so this has to be bypass-merged and then I can update the rules.

@guggero guggero merged commit 4a37e62 into master May 7, 2025
21 of 22 checks passed
@guggero guggero deleted the tapd-main branch May 7, 2025 17:11
@guggero
Copy link
Member Author

guggero commented May 7, 2025

@ViktorTigerstrom okay, I updated the required steps. I decided to not include the custom channels one, since it's still flakey. Will include it as required once it's more stable (hopefully soon).

@ViktorTigerstrom
Copy link
Contributor

Awesome, thanks 🎉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog This PR is does not require a release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants