[sql-22] session: sessions CRUD #996
Merged
+1,034
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
sql22Sessions14
branch
from
2e7e99c to
1988690
Compare
ellemouton
added
the
no-changelog
ellemouton
force-pushed
the
sql22Sessions14
branch
2 times, most recently
from
d2de94b to
71cdc5a
Compare
bitromortac
reviewed
Mar 13, 2025
| } | ||
|
|
||
| var macRecipe *MacaroonRecipe | ||
| if perms != nil || caveats != nil { |
There was a problem hiding this comment.
is it ok to check only for whether one one them is present?
There was a problem hiding this comment.
yes - look at the calls that follow
Comment on lines
+643
to
+656
| sessIDs, err := db.GetSessionAliasesInGroup( | ||
| ctx, sql.NullInt64{ | ||
| Int64: groupID, | ||
| Valid: true, | ||
| }, | ||
| ) | ||
| if err != nil { | ||
| return fmt.Errorf("unable to get session IDs: %v", err) | ||
| } |
There was a problem hiding this comment.
Just noting that original logic actually seems to error if no sessions for the legacyGroupID is found, while this would return an emprty list. But given that I think the new logic is actually more correct, and I don't see a scenario where we'd hit that anyways, I think we should probably keep as is.
|
@ellemouton, remember to re-request review from reviewers when ready |
ellemouton
force-pushed
the
sql22Sessions14
branch
from
71cdc5a to
7feac60
Compare
ellemouton
commented
Mar 24, 2025
| } | ||
|
|
||
| var macRecipe *MacaroonRecipe | ||
| if perms != nil || caveats != nil { |
There was a problem hiding this comment.
yes - look at the calls that follow
ViktorTigerstrom
approved these changes
Mar 25, 2025
This commit adds the SQL implementation of the session.Store interface. This can be run against all session unit tests via `make unit pkg=session tags=test_db_sqlite` and `make unit pkg=session tags=test_db_postgres`.
Let LiTd support a SQL db for the sessions store under the `dev` build tag. This can be used via itests.
ellemouton
force-pushed
the
sql22Sessions14
branch
from
7feac60 to
6dbf880
Compare
ellemouton
commented
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the SQL implementation of the
sessions.Storeis added.part of #917