Skip to content

signer: add MuSig2 combined nonce registration methods#261

Merged
Roasbeef merged 1 commit intolnd-21-0from
musig2-combined-nonce
Jan 13, 2026
Merged

signer: add MuSig2 combined nonce registration methods#261
Roasbeef merged 1 commit intolnd-21-0from
musig2-combined-nonce

Conversation

@Roasbeef
Copy link
Member

This commit adds two new methods to the SignerClient interface:

  • MuSig2RegisterCombinedNonce: Registers a pre-aggregated combined nonce for a session. This is an alternative to MuSig2RegisterNonces and is used when a coordinator has already aggregated all individual nonces.

  • MuSig2GetCombinedNonce: Retrieves the combined nonce for a session after it becomes available.

These methods are needed for coordinator-based MuSig2 signing workflows. Also updates lnd dependency to include sqldb v1.0.12.

@Roasbeef Roasbeef requested a review from bhandras January 13, 2026 02:42
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should merge this to master as it's tracking v0.20, rather we should create lnd-21-0 branch merge there and tag as v0.21.0-1?

@Roasbeef Roasbeef changed the base branch from master to lnd-21-0 January 13, 2026 18:39
@Roasbeef
Copy link
Member Author

I don't think we should merge this to master as it's tracking v0.20, rather we should create lnd-21-0 branch merge there and tag as v0.21.0-1?

Done 👍

This commit adds two new methods to the SignerClient interface:

- MuSig2RegisterCombinedNonce: Registers a pre-aggregated combined nonce
  for a session. This is an alternative to MuSig2RegisterNonces and is
  used when a coordinator has already aggregated all individual nonces.

- MuSig2GetCombinedNonce: Retrieves the combined nonce for a session
  after it becomes available.

These methods are needed for coordinator-based MuSig2 signing workflows.
Also updates lnd dependency to include sqldb v1.0.12.
@Roasbeef Roasbeef force-pushed the musig2-combined-nonce branch from aefc13f to cc80880 Compare January 13, 2026 19:08
@Roasbeef Roasbeef merged commit 440cd36 into lnd-21-0 Jan 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants