[4/?] StaticAddr: Instant deposit withdrawals #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
static-addr-4
branch
4 times, most recently
from
309bcdc to
4611204
Compare
bhandras
reviewed
Apr 5, 2024
hieblmi
force-pushed
the
static-addr-4
branch
3 times, most recently
from
c5e9e9d to
c7d2160
Compare
hieblmi
force-pushed
the
static-addr-4
branch
9 times, most recently
from
c204e8d to
34f843c
Compare
hieblmi
force-pushed
the
static-addr-4
branch
5 times, most recently
from
bc540a6 to
1b4ca0c
Compare
hieblmi
force-pushed
the
static-addr-staging
branch
from
f614090 to
70a74bd
Compare
hieblmi
force-pushed
the
static-addr-4
branch
2 times, most recently
from
bc8e20c to
fb1300f
Compare
hieblmi
force-pushed
the
static-addr-staging
branch
5 times, most recently
from
bb36baf to
28239df
Compare
hieblmi
force-pushed
the
static-addr-4
branch
3 times, most recently
from
fc7f4d1 to
dd75d00
Compare
sputn1ck
approved these changes
Jun 4, 2024
| expiry_sweep_txid BLOB | ||
| expiry_sweep_txid BLOB, | ||
|
|
||
| -- withdrawal_sweep_pk_script is the address that will be used to sweep the |
hieblmi
force-pushed
the
static-addr-staging
branch
from
28239df to
dbc351a
Compare
hieblmi
force-pushed
the
static-addr-4
branch
2 times, most recently
from
6d65aaf to
64dd989
Compare
hieblmi
force-pushed
the
static-addr-staging
branch
from
dbc351a to
c4012d0
Compare
hieblmi
force-pushed
the
static-addr-4
branch
2 times, most recently
from
56169ab to
848cf09
Compare
Deposit schema extension with a withdrawal sweep address. If the user selects a deposit for withdrawal the destination address of the sweep is stored here.
A new rpc for deposit withdrawals is added. A withdrawal cooperatively spends the 2/2 musig deposit outpoint to a client-specified address.
A server endpoint to obtain a partial sig to cooperatively spend a 2/2 musig deposit outpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables instant withdrawals of funds at static address deposits, allowing the client to omit the CSV timeout period of their Musig2 outpoints and cooperatively spend selected deposit outpoints cooperatively with the server.
Withdrawing can be done for selected or all eligible deposits. Examples:
Selected deposit:
All deposits: