sweepbatcher: add more debug logging #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
approved these changes
Apr 30, 2024
starius
approved these changes
Apr 30, 2024
sweepbatcher/sweep_batch.go
Outdated
| len(batchTx.TxIn), address.String()) | ||
| b.log.Infof("attempting to publish non-coop tx=%v with feerate=%v, "+ | ||
| "totalfee=%v, sweeps=%v, destAddr=%s", batchTx.TxHash(), | ||
| b.rbfCache.FeeRate, fee, len(batchTx.TxIn), address.String()) |
There was a problem hiding this comment.
.String() call can be omitted (%s instructs printf-like functions to call it).
Also in another instance below in the PR.
sweepbatcher/sweep_batch.go
Outdated
| "totalfee=%v, sweeps=%v, destAddr=%s", b.rbfCache.FeeRate, fee, | ||
| len(batchTx.TxIn), address.String()) | ||
| b.log.Infof("attempting to publish non-coop tx=%v with feerate=%v, "+ | ||
| "totalfee=%v, sweeps=%v, destAddr=%s", batchTx.TxHash(), |
There was a problem hiding this comment.
I suggest to replace sweeps=%v with sweeps=%d, because it is known to be int.
Also in another instance below in the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes