fsm: add WaitForStateAsync to the cached observer #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
force-pushed
the
fsm-observer-fixup
branch
from
161c4a5 to
e5b2f2b
Compare
bhandras
force-pushed
the
fsm-observer-fixup
branch
from
e5b2f2b to
e6e596b
Compare
hieblmi
reviewed
May 8, 2024
fsm/observer.go
Outdated
| // receive an error if the expected state is reached or an error occurred. If | ||
| // the context is canceled before the expected state is reached, the channel | ||
| // will receive an ErrWaitingForStateTimeout error. | ||
| func (s *CachedObserver) WaitForStateAsync(ctx context.Context, state StateType, |
There was a problem hiding this comment.
nit: rename receiver c here and in WaitForState.
bhandras
force-pushed
the
fsm-observer-fixup
branch
from
e6e596b to
eddb8dc
Compare
bhandras
force-pushed
the
fsm-observer-fixup
branch
from
eddb8dc to
24c30ee
Compare
hieblmi
approved these changes
May 8, 2024
fsm/observer.go
Outdated
| } | ||
| } | ||
|
|
||
| // Otherwise, wait for the next notification | ||
| s.notificationCond.Wait() | ||
| // Otherwise use the conditonal variable to wait for |
By adding WaitForStateAsync to the observer we can always observe state changes in an atomic way without relying on the observer's internal cache.
bhandras
force-pushed
the
fsm-observer-fixup
branch
from
336d336 to
811e9df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding WaitForStateAsync to the observer we can always observe state changes in an atomic way without relying on the observer's internal cache.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes