loopout: fix negative reported fees #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
reviewed
May 22, 2024
bhandras
force-pushed
the
negative-fees-fixup
branch
from
cf90e11 to
a48944a
Compare
hieblmi
approved these changes
May 23, 2024
starius
approved these changes
May 23, 2024
loopout.go
Outdated
| s.cost.Server += result.status.Value.ToSatoshis() - | ||
| s.AmountRequested | ||
| s.cost.Offchain += result.status.Fee.ToSatoshis() | ||
| if result.status.Preimage == s.SwapContract.Preimage { |
There was a problem hiding this comment.
Please add a comment about this check (about the scenarios).
There was a problem hiding this comment.
Instead I added a flag to indicate this is a swap payment and some comments explaining what we're doing when calculating the costs.
bhandras
force-pushed
the
negative-fees-fixup
branch
from
a48944a to
5690235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes