staticaddr: channel funding with deposits by hieblmi · Pull Request #937 · lightninglabs/loop

hieblmi · 2025-05-08T20:30:38Z

This PR introduces a openchannel subcommand to static addresses.

It provides the same experience as lncli openchannel.
Exmples:

Open a channel with all available deposits:

loop static openchannel --fundmax --sat_per_vbyte XXX --private ...

Open a channel with specified local funding amount, coin-selected from available deposits under fee and dust considerations.

loop static openchannel --local_amt XXX --sat_per_vbyte YYY --private ...

Open a channel from two deposits AAA and BBB while taking their combined value(fundmax) as funding amount and considering fees and dust limit.

loop static openchannel --utxo AAA --utxo BBB --fundmax --sat_per_vbyte YYY --private ...

Open a channel from two deposits AAA and BBB while taking a specified amount(local_amt) as funding amount and considering fees and dust limit.

loop static openchannel --utxo AAA --utxo BBB --local_amt --sat_per_vbyte YYY --private ...

TODOs:

Integration tests

hieblmi · 2025-05-28T09:57:50Z

Rebased

hieblmi · 2025-06-30T14:57:42Z

Rebased

hieblmi · 2025-07-02T21:00:17Z

Rebased master

hieblmi · 2025-07-17T13:37:33Z

Rebased master.

hieblmi · 2025-10-20T12:17:45Z

Rebased with latest master

starius

Started reviewing the PR.
I propose to dedup channel open related proto types with LND, see hieblmi#2

starius · 2025-10-21T15:04:49Z

staticaddr/staticutil/utils.go

@@ -0,0 +1,134 @@
+package staticutil


Non-ascii characters in the commit message. I think we can remove it.

starius · 2025-10-21T16:48:54Z

staticaddr/staticutil/utils.go

+)
+
+// ToPrevOuts converts a slice of deposits to a map of outpoints to TxOuts.
+func ToPrevOuts(deposits []*deposit.Deposit,


I propose to cover the function with unit tests.

starius · 2025-10-21T16:52:42Z

staticaddr/withdraw/manager.go

-	)
-}
-
 func (m *Manager) toPrevOuts(deposits []*deposit.Deposit,


Shouldn't this method reuse staticutil.ToPrevOuts?

Also we have loopin.StaticAddressLoopIn.toPrevOuts method. I guess it should also reuse staticutil.ToPrevOuts, right?

Yes right, fixed it.

starius · 2025-10-21T16:57:11Z

staticaddr/staticutil/utils.go

+	signer lndclient.SignerClient, deposits []*deposit.Deposit,
+	addrParams *address.Parameters,
+	staticAddress *script.StaticAddress) ([]*input.MuSig2SessionInfo,
+	[][]byte, error) {


I propose to cover the function with unit tests.

starius · 2025-10-21T16:57:30Z

staticaddr/staticutil/utils.go

+}
+
+// CreateMusig2Sessions creates a musig2 session for a number of deposits.
+func CreateMusig2Sessions(ctx context.Context,


Can we reuse this function in loopin.StaticAddressLoopIn.createMusig2Sessions?

yes, I removed the methods in loopin and use the methods in staticutil instead.

starius · 2025-10-23T18:49:43Z

looprpc/client.proto

        returns (StaticAddressSummaryResponse);

-    /* loop:`static`
+    /* loop:`in`


Maybe static in?

FIxed in hieblmi#2

starius · 2025-10-23T18:50:10Z

looprpc/client.proto

    rpc StaticAddressLoopIn (StaticAddressLoopInRequest)
        returns (StaticAddressLoopInResponse);
+
+    /* loop:`openchannel`


static openchannel?

Fixed in hieblmi#2

starius · 2025-10-23T18:51:40Z

looprpc/client.proto

+    /*
+    An optional error string.
+    */
+    string error = 2;


Can't we deliver errors via gRPC errors?

yep, removed this field.

starius · 2025-10-27T05:37:34Z

looprpc/client.proto

    uint64 asset_cost_offchain = 3;
 }
+
+message OpenChannelRequest {


PTAL at hieblmi#2
I removed all the code below this line from this file and used the original LND types from lntypes.

starius · 2025-10-28T03:52:59Z

I noticed that static loop-in methods are missing in file looprpc/client.yaml
Should we add them there?
I sent PR #1026
If we add the methods, we also need to add the openchannel method there.

lightninglabs-deploy · 2025-11-11T14:36:42Z

@starius: review reminder

Make our own type StaticAddressLoopInRequest which has a single field of type lnrpc.OpenChannelRequest. Removed copy-pasted lnrpc types which are needed for OpenChannelRequest.

hieblmi self-assigned this May 8, 2025

hieblmi added the static-loop-in label May 8, 2025

hieblmi marked this pull request as draft May 8, 2025 20:31

hieblmi force-pushed the static-open-channel branch 2 times, most recently from 60286d0 to 97049c1 Compare May 9, 2025 09:20

hieblmi mentioned this pull request May 9, 2025

Partial loop-in/withdrawal from static loop address #873

Closed

hieblmi force-pushed the static-open-channel branch 6 times, most recently from 6c330e5 to 4184f2d Compare May 21, 2025 12:19

hieblmi changed the title ~~[WIP] staticaddr: channel funding with deposits~~ staticaddr: channel funding with deposits May 21, 2025

hieblmi marked this pull request as ready for review May 21, 2025 12:22

hieblmi force-pushed the static-open-channel branch 4 times, most recently from fbe14d2 to 59975f0 Compare May 28, 2025 09:57

hieblmi added the big size label Jun 17, 2025

hieblmi force-pushed the static-open-channel branch from 59975f0 to 596b1df Compare June 30, 2025 14:57

hieblmi force-pushed the static-open-channel branch from 596b1df to 4d0e787 Compare July 2, 2025 17:01

hieblmi force-pushed the static-open-channel branch from 4d0e787 to 818b915 Compare July 17, 2025 13:37

hieblmi force-pushed the static-open-channel branch from 818b915 to c4dc989 Compare October 7, 2025 12:27

hieblmi force-pushed the static-open-channel branch 2 times, most recently from bf7bd29 to 7bd2fd0 Compare October 20, 2025 10:44

hieblmi requested review from bhandras and sputn1ck October 20, 2025 13:31

starius reviewed Oct 27, 2025

View reviewed changes

hieblmi force-pushed the static-open-channel branch from a0fe637 to 706c1ff Compare October 27, 2025 14:10

hieblmi force-pushed the static-open-channel branch 3 times, most recently from f9f6792 to a2d4650 Compare November 3, 2025 15:19

hieblmi requested a review from starius November 3, 2025 16:04

hieblmi force-pushed the static-open-channel branch 2 times, most recently from 97653cd to 35cbada Compare November 4, 2025 14:31

starius mentioned this pull request Nov 4, 2025

looprpc: reuse LND proto types for open channel hieblmi/loop#2

Closed

1 task

hieblmi force-pushed the static-open-channel branch 2 times, most recently from 52e1651 to e05a2ca Compare November 5, 2025 14:49

hieblmi closed this Nov 11, 2025

hieblmi force-pushed the static-open-channel branch from e05a2ca to 16d56f1 Compare November 11, 2025 19:23

hieblmi added 9 commits November 11, 2025 20:26

staticaddr: refactor methods into utils

a244b21

looprpc: reuse LND proto types for open channel

d49381f

Make our own type StaticAddressLoopInRequest which has a single field of type lnrpc.OpenChannelRequest. Removed copy-pasted lnrpc types which are needed for OpenChannelRequest.

swapserverrpc: psbt-base ServerWithdraw endpoint

b623f05

staticutil: channel open functions

fb31e06

staticaddr: channel open states for deposit and fsm

53945bf

staticaddr: open channel manager

38acfbb

loopd: instantiate static address open channel manager

1d98e76

cmd: open channel command

bd856ef

docs: update loop.md

5466165

hieblmi reopened this Nov 11, 2025

hieblmi closed this Nov 11, 2025

hieblmi deleted the static-open-channel branch November 11, 2025 20:05

hieblmi restored the static-open-channel branch November 11, 2025 20:06

Conversation

hieblmi commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hieblmi commented May 28, 2025

Uh oh!

hieblmi commented Jun 30, 2025

Uh oh!

hieblmi commented Jul 2, 2025

Uh oh!

hieblmi commented Jul 17, 2025

Uh oh!

hieblmi commented Oct 20, 2025

Uh oh!

starius left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

starius commented Oct 28, 2025

Uh oh!

lightninglabs-deploy commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hieblmi commented May 8, 2025 •

edited

Loading