Skip to content

[group key addrs 2/?]: internal/ecies: add encrypt/decrypt with ECIES #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guggero
Copy link
Member

@guggero guggero commented May 6, 2025

Implements the ECIES encryption scheme as mentioned here: #874 (comment)

This commit creates a simple encryption and decryption function that uses AES256-GCM for tne symmetric encryption and HKDF with SHA256 for the key derivation.
The shared key generation is not part of these functions, because we'll need to use lnd RPCs in some cases to be able to derive it.

This commit creates a simple encryption and decryption function that
uses AES256-GCM for tne symmetric encryption and HKDF with SHA256 for
the key derivation.
The shared key generation is not part of these functions, because we'll
need to use lnd RPCs in some cases to be able to derive it.
@guggero guggero requested a review from Roasbeef May 6, 2025 08:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14855573634

Details

  • 59 of 82 (71.95%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.1%) to 37.071%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/ecies/ecies.go 59 82 71.95%
Files with Coverage Reduction New Missed Lines %
address/address.go 2 69.55%
asset/group_key.go 2 57.89%
tapgarden/planter.go 2 60.85%
commitment/tap.go 4 71.82%
tapchannel/aux_leaf_signer.go 5 43.08%
Totals Coverage Status
Change from base Build 14790497726: 0.1%
Covered Lines: 26580
Relevant Lines: 71701

💛 - Coveralls

@levmi levmi added the P1 label May 8, 2025
@levmi levmi added this to the v0.7 milestone May 8, 2025
@levmi levmi moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants