itest flake: fixes flake in burn test #1514
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to specify a pkg= and case= argument to the flake-unit-race test.
Before we refactor the ordering, we add a unit test to make sure we don't change the behavior.
We refactor the input piece sort mechanism and export the main comparison function so we can re-use it in other packages to do the same ordering where necessary.
This fixes a bug where the order of the inputs in a virtual packet wasn't deterministic, because we only sorted the proofs _after_ already assigning them as inputs to the packet.
This fixes the main part of the flake that caused burns to sometimes not be recognized correctly. Because we now also use the allocation code to create virtual packets, we need to apply the same ordering of inputs to the selected commitments before choosing the first input that the burn key is derived from. Otherwise it can happen that the actual first input in the allocated virtual transaction is another one and the resulting burn key isn't recognized correctly.
Pull Request Test Coverage Report for Build 14867407240Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a flake in the integration test that happens since we refactored the burn funding logic to use the allocation code for creating virtual packets.