minting: fix re-issuing into existing group with external key #1517
Conversation
This commit fixes two checks that prevented us to re-issue more assets into an existing group using an external group key.
Turns out we didn't really set up the group minting request properly to mint into an existing group. Before this change we'd simply mint a completely new group, using the same external key.
|
so this is ready to test? |
Yes. |
Pull Request Test Coverage Report for Build 14864958611Details
💛 - Coveralls |
| } | ||
|
|
||
| if group.GroupKey.RawKey.PubKey == nil { | ||
| return fmt.Errorf("group raw key is " + |
There was a problem hiding this comment.
is this the same as
taproot-assets/taprpc/mintrpc/mint.proto
Lines 216 to 226 in 5225722
| err := fn.MapOptionZ( | ||
| c.ExternalKey, func(extKey asset.ExternalKey) error { | ||
| if group.GroupKey == nil { | ||
| return fmt.Errorf("group key is nil") |
There was a problem hiding this comment.
is this the same as tweaked_group_key?
| err) | ||
| } | ||
|
|
||
| // If it's not an external key, we need to check that we can actually |
There was a problem hiding this comment.
so this would mean
taproot-assets/taprpc/mintrpc/mint.proto
Lines 174 to 182 in 5225722
| @@ -2668,7 +2668,11 @@ func (c *ChainPlanter) prepAssetSeedling(ctx context.Context, | |||
| // If a group internal key or tapscript root is specified, emission must | |||
| // also be enabled. | |||
| if !req.EnableEmission { | |||
| if req.GroupInternalKey != nil { | |||
| // For re-issuance or regular assets, the group internal key | |||
There was a problem hiding this comment.
do you mean "of" instead of "or"?
| // shouldn't be set. It is, however, set for re-issuance with | ||
| // an external key, because the internal group key is the key | ||
| // we compare the external key against. | ||
| if req.GroupInternalKey != nil && req.ExternalKey.IsNone() { | ||
| return fmt.Errorf("cannot specify group internal key " + | ||
| "without enabling emission") |
There was a problem hiding this comment.
https://lightning.engineering/api-docs/api/taproot-assets/mint/mint-asset/ does not really use the word "emission" except in CLI example. can we add "emission" to
taproot-assets/taprpc/mintrpc/mint.proto
Lines 153 to 159 in 5225722
| if req.GroupInternalKey != nil { | ||
| // For re-issuance or regular assets, the group internal key | ||
| // shouldn't be set. It is, however, set for re-issuance with | ||
| // an external key, because the internal group key is the key |
There was a problem hiding this comment.
generally, I'm confused here what this whole comment means.
Fixes #1515.
Fixes #1516.