tapdb: format SQL using SQLFluff #1616
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15853021857Details
💛 - Coveralls |
Because the linter now forces us to always use lowercase function names, we also need to do that to the (case sensitive!) postgres schema replacement map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses SQLFluff to format and lint SQL migration and query files.
Inspired by #1612 (comment).
NOTE: This does change existing migration script files that have already run on most machines. But since the changes are only in the formatting, no actual schema changes are performed by this PR.
There are two new
makegoals:make sql-lint: Run the linter as it runs in the CI to detect formatting issues in the SQL files intapdb/sqlc/migrations/* tapdb/sqlc/queries/*make sql-fix: Attempt to fix the linter issues in the SQL files intapdb/sqlc/migrations/* tapdb/sqlc/queries/*