AddInvoice correctly handles existing route hints
#1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15973315571Details
💛 - Coveralls |
ffranr
approved these changes
Jul 3, 2025
Comment on lines
+431
to
+445
| for _, hint := range hints { | ||
| for _, h := range hint.HopHints { | ||
| scid := h.ChanId | ||
| buyQuote, ok := buyQuotes[rfqmsg.SerialisedScid(scid)] | ||
| if !ok { | ||
| continue | ||
| } | ||
|
|
||
| quoteSpecifier := buyQuote.Request.AssetSpecifier | ||
|
|
||
| if quoteSpecifier.String() == specifier.String() { | ||
| return &buyQuote | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we check that there are no other quotes here? So exhaustively check: find the quote, but then keep looking and error if we find another matching quote.
There was a problem hiding this comment.
It's not really crucial to not have competing quotes here, as we're just picking one to create the invoice over.
For the case where the user wants to provide multiple quotes for a multi-rfq receive we're going to introduce the RPC level rfq_ids field, which would also eliminate the need to manually create a []RouteHints argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After merging #1359 we changed some of the logic around acquiring quotes in
taprpc.AddInvoice. A special edge case where the user has already negotiated a quote and included it in thelnrpc.Invoiceroute hints would lead into a crash as a variable would remain unset.Closes #1622