tapdb: support delegation key and universe commitment flag in seedlings #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid calculating the asset anchor output index based on the ChangeOutputIndex, as this approach may not correctly account for the presence of the pre-commitment output.
This commit updates the seedling storage logic to support delegation keys. The delegation keys themselves are stored in the internal keys table, and a reference to the relevant key is now saved in the asset_seedlings table.
Update the NewMintingBatch SQL query to support setting the universe commitments flag. While the flag is currently set when the anchor transaction is assigned to the batch (i.e., during funding), this change adds the same support to CommitMintingBatch for completeness.
Update seedling retrieval logic to parse the delegation key field from the database.
Add support for inserting and fetching the universe commitments flag on the seedling when writing to and reading from the database.
Add a unit test to verify that the universe commitments flag is correctly set on both the batch and seedling during database read and write operations.
Pull Request Test Coverage Report for Build 16061500957Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work towards completing #1534
Store and fetch delegation key references to/from the
asset_seedlingstable.Add support for persisting the universe commitment flag in both
asset_seedlingsandminting_batches.Add unit tests to verify flag round-trips correctly through the DB.
Other:
ChangeOutputIndexwhen deriving asset anchor output index.