Skip to content

rpcserver: return early on rejected quote #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GeorgeTsagk
Copy link
Member

Description

When an RFQ negotiation fails we return the rfq.InvalidQuoteRespEvent event to the RPC subscriber. Previously this message was ignored, causing the RPC endpoint to only return when the timeout occured. Now we immediatelly return when an RFQ negotiation failure occurs

@GeorgeTsagk GeorgeTsagk self-assigned this Jul 4, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16077853549

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 39.282%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
asset/group_key.go 2 62.64%
commitment/tap.go 2 72.05%
tappsbt/create.go 2 26.74%
tapchannel/aux_invoice_manager.go 6 80.51%
Totals Coverage Status
Change from base Build 16059643780: 0.04%
Covered Lines: 30684
Relevant Lines: 78112

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants