[custom channels 3/3]: add FundingController to manage channel asset funding #882
Merged
[custom channels 3/3]: add FundingController to manage channel asset funding #882
Conversation
guggero
reviewed
Apr 16, 2024
Contributor
guggero
left a comment
There was a problem hiding this comment.
Awesome, looks very good! Left some suggestions and clarifications to make sure we have the same flow in mind.
e437f07 to
33067d0
Compare
486831a to
d8f3190
Compare
33067d0 to
d7b3b87
Compare
d7b3b87 to
f7b587a
Compare
dd47bfd to
c7135e7
Compare
d50cee9 to
f616b28
Compare
c7135e7 to
bbcd2fb
Compare
This was referenced May 17, 2024
f616b28 to
908b6f3
Compare
80b004a to
eb7bb32
Compare
Contributor
|
Ready for full review. |
2fc91ba to
516c4d4
Compare
733b8b6 to
2a4ea41
Compare
516c4d4 to
370a717
Compare
2a4ea41 to
9133857
Compare
ffranr
suggested changes
May 23, 2024
ffranr
suggested changes
May 23, 2024
370a717 to
feea448
Compare
9133857 to
4cbfbc7
Compare
4cbfbc7 to
fc79c5b
Compare
ffranr
reviewed
May 27, 2024
ffranr
approved these changes
May 27, 2024
Contributor
ffranr
left a comment
There was a problem hiding this comment.
Just one comment here to consider: #882 (comment)
fc79c5b to
c7cdf47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we add a new sub-system, that
FundingControllerwhich is tasked with managing the asset channel funding process from start to finish. The new funding sub-system will communicate directly with an lnd node (in-process or via RPC) to drive the funding process with an externally funded PSBT template. We'll interact with the localAssetWalletto funding+sign the PSBT on all levels, then ask lnd to validate what we've created, before finally broadcasting the final transaction. Before we kick off the funding process, we'll send a series of input validation proofs to the remote party. They'll validate these proofs (sent as custom messages) to ensure that we can actually sign for the assets sent.Link to all PRs in the saga:
TODO
PsbtChannelFunder