RFQ modifications derived from the tap channels proof-of-concept#904
Merged
RFQ modifications derived from the tap channels proof-of-concept#904
Conversation
ffranr
changed the title
Contributor
Author
|
I still need to unpack the |
ffranr
force-pushed
the
rfq-poc-modifications
branch
2 times, most recently
from
6c3e7ea to
3a3de0b
Compare
guggero
reviewed
May 20, 2024
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Very nice PR, well done! Super easy to review.
A couple of small-is things, think this is super close already 💯
This test is disabled until we can set the `WireCustomRecords` field in the `UpdateAddHtlc` p2p message first hop.
- Bump lnd to commit 7953d67dbc28. - Bump lndclient to commit cd497ef6. - Bump lnd/tlv to commit v1.2.6.
We add the asset ID field as a workaround for RFQ session persistence.
We add the asset ID field as a workaround for RFQ session persistence.
This method will allow us to derive a TLV record from an RFQ ID.
GeorgeTsagk
reviewed
May 20, 2024
guggero
reviewed
May 20, 2024
This commit splits the method `Manager.QueryPeerAcceptedQuotes` into methods `PeerAcceptedBuyQuotes` and `PeerAcceptedSellQuotes`.
This commit is a temporary simplification that allows the channels proof-of-concept to function.
This commit also sets a timeout which was previously missing.
This commit introduces code allowing the RFQ order manager to inspect htlc custom records and determine if asset balance modifications comply with the corresponding agreed RFQ quote.
This commit modifies the RPC endpoints `AddAssetBuyOrder` and `AddAssetSellOrder` such that they are blocking. A timeout parameter is also added to each endpoint.
ffranr
force-pushed
the
rfq-poc-modifications
branch
from
3a3de0b to
2219033
Compare
guggero
approved these changes
May 21, 2024
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Very nice, awesome work! LGTM 🎉
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2024
RFQ modifications derived from the tap channels proof-of-concept
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates changes to the RFQ service based on the tap channels proof-of-concept code.