tapdb: implement basic migration downgrade protection #973
+128
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharveyb
approved these changes
Jun 25, 2024
In this commit, we implement basic migration downgrade protection. This ensures that tapd will refuse to downgrade versions if a migration happened in the latest software version. We achieved this by hard coding the latest version as a constant. Then when we go to migrate, we check this version against the latest version stored in the database. If the hard coded version is less than the latest version, then we conclude this is a downgrade attempt.
Roasbeef
force-pushed
the
prevent-db-downgrade
branch
from
f288136 to
5b6c6b8
Compare
dstadulis
requested review from
ffranr and
gijswijs
and removed request for
ffranr
|
Added a commit to check the hard coded version in the Golang code with a CI step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we implement basic migration downgrade protection. This ensures that tapd will refuse to downgrade versions if a migration happened in the latest software version.
We achieved this by hard coding the latest version as a constant. Then when we go to migrate, we check this version against the latest version stored in the database. If the hard coded version is less than the latest version, then we conclude this is a downgrade attempt.