-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feature: start to set the require bit for channel_type #9637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Note that this keeps in place the old implicit channel type negotiation logic for now. |
Related to this spec PR: lightning/bolts#1232. To start with, we'll start to set the required feature bit for the `channel_type` feature where applicable.
12ecea3
to
8266b96
Compare
Related to this spec PR: lightning/bolts#1232.
To start with, we'll start to set the required feature bit for the
channel_type
feature where applicable.