input: update taproot scripts to add an option for the miniscript compat versions from latest spec #9639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we switch to using the new txscript.ScriptTemplate function. This allows us to write the script in plain text, using some hidden template operations to swap in items like keys or sigs. This reduces in less code and boiler plate over all, the code that defines the script now reads as if it was a comment.
In this commit, we add an initial cut out to allow us to swap in the taproot scripts (which changed slightly) once we start using the final "production" feature bit. The changes to the scripts are pretty mechanic: we avoid using `OP_DROP` and instead use a `_VERIFY` earlier in the script to consume the stack item.
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we add an initial cut out to allow us to swap in the
taproot scripts (which changed slightly) once we start using the final
"production" feature bit.
The changes to the scripts are pretty mechanic: we avoid using
OP_DROPand instead use a
_VERIFYearlier in the script to consume the stackitem.
Along the way we start using
txsscript.ScriptTemplateto cut down on some of the boilerplate needed when making scripts.
This PR is dependent on btcsuite/btcd#2216
In a follow up PR, we'll start to pass in this new argument based on which taproot channel
version was negotiated.