add --verbose option #332
Merged
add --verbose option #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisbouvier
approved these changes
Dec 16, 2024
| @@ -334,3 +347,18 @@ pub fn main() !void { | |||
| }, | |||
| } | |||
| } | |||
|
|
|||
| var verbose: bool = builtin.mode == .Debug; // In debug mode, force verbose. | |||
There was a problem hiding this comment.
Not a big fan of this global variable but I guess it's not possible to do without, at least if we want to keep using the std lib log function.
There was a problem hiding this comment.
Well, I think have a global var in the main.zig is not perfect, but ok.
| ) void { | ||
| if (!verbose) { | ||
| // hide all messages with level greater of equal to debug level. | ||
| if (@intFromEnum(level) >= @intFromEnum(std.log.Level.debug)) return; |
There was a problem hiding this comment.
As debug is the last level I think checking an equality should be more clear. But of course like that you can't handle addition lowers levels. So it's also good to me like.
There was a problem hiding this comment.
But Since we filter here, I do prefer the >= to avoid more verbose messages if a lower level is added by Zig later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
--verboseto enable debug output.In debug mode, verbose is forced to
true.