Add readystate change event to XHR #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deal with non-node current target crashing. Builds ontop of abort_signal, but with the new event-target specific union, I think this will work in for all future cases.
karlseguin
force-pushed
the
xhr_readystatechange
branch
from
3d8cc2a to
dfe9024
Compare
sjorsdonkers
reviewed
Jul 4, 2025
There was a problem hiding this comment.
I'm wondering whether it would be good to also implement the state change on abort now:
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/abort
I tried to improve that too now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with non-node current target crashing. Builds ontop of abort_signal, but with the new event-target specific union, I think this will work in for all future cases.