Closed
Conversation
Collaborator
|
Standalone, this PR is fine. But from the corresponding Browser PR (lightpanda-io/browser#524) I wonder if it isn't better to encapsulate the details. I'm not sure the CDP layer should know anything about a JSValue or an ExternalEntry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose unwrapObject via getValueByObjectId for use in describeNode
Note that we do not use the context nor objectGroup, perhaps we may need these in the future if the registry is context specific?
Depends on: lightpanda-io/zig-v8-fork#51