Fix bug: continue processing model if skeleton check fails #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a problem in
src/tydra/render-data.cc
around line3704
. If the skeleton check fails, the model processing is aborted at that point, instead of continuing with other crucial model processing steps...If the logic is inverted and early (aborting) return removed, the model processing is allowed to continue even if the skeleton check fails
Additional details in #176