perf: reserve memory for prim children #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
How much the performance will be improved with this PR? |
Contributor
Author
|
I used CPU usage by usdc file for testing: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to optimize performance by reserving memory for prim children to reduce frequent vector reallocations.
- Added a conditional check on currPrimPtr and reserved the necessary capacity based on the number of children.
| const crate::CrateReader::Node &node = _nodes[size_t(current)]; | ||
| DCOUT("node.Children.size = " << node.GetChildren().size()); | ||
| if (currPrimPtr) { | ||
| currPrimPtr->children().reserve(node.GetChildren().size()); |
There was a problem hiding this comment.
Consider caching node.GetChildren().size() in a local variable before both reserving and iterating over the children to avoid multiple function calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the performance of constructing prims, avoiding too frequent reallocation of the children vector.