feat: output in json format option #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
reviewed
Jun 23, 2025
src/Command/HealthCheckCommand.php
Outdated
| $isFail = $results->defects(...$failureStatuses)->count() > 0; | ||
|
|
||
| if ($isJsonOutput) { | ||
| $output->write(\json_encode($results, \JSON_THROW_ON_ERROR, 512)); |
There was a problem hiding this comment.
I'm guessing this is meant to be read by some kind of automated script but would it hurt to add JSON_PRETTY_PRINT?
There was a problem hiding this comment.
It makes no difference in our case. I Added it
kbond
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--jsonoption to the health check command. It is a bit "hacky" so let me know if you want me to do this differently. This pull request also contains the fix from 316Thanks