Apply CS fixes to get rid of PHP 8.4 deprecations #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also support the latest fixes for PHP 8.4
Some of the rector rules got removed and could no longer be used. The ones that could be replaced where replaced, others were removed without rector providing an alternative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Applying mainly CS fixes so the code no longer throws deprecation messages in PHP 8.4
I also updated to the latest rector version and removed (or replaced with the new alterntaive) the rules which no longer existed.
Why?
Get rid of deprecation notices when using PHP 8.4
Checklist
This will also support the latest fixes for PHP 8.4