-
Notifications
You must be signed in to change notification settings - Fork 11
chore: sync node-websocket to upstream #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2f3a7e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR syncs the node-websocket
package to the upstream Astro repository by updating the git submodule reference from withastro/adapters
to withastro/astro
and upgrading from @astrojs/[email protected]
to @astrojs/[email protected]
. Additionally, it includes improvements to WebSocket test conditions and adds new properties to the astro-global
package.
Key Changes:
- Updated git submodule from
withastro/adapters
towithastro/astro
repository - Upgraded
@astrojs/node
version from 9.0.2 to 9.3.0 - Improved WebSocket test conditions to check for
WebSocket
availability instead of Node.js version - Added new properties to
astro-global
package for directive and resource insertion
Reviewed Changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
.gitmodules |
Updated submodule path and URL to point to withastro/astro |
packages/node-websocket/withastro/adapters |
Removed old submodule |
packages/node-websocket/withastro/astro |
Added new submodule pointing to astro repository |
packages/node-websocket/package.json |
Updated paths, dependencies, and scripts for new submodule structure |
packages/node-websocket/*.patch |
Updated patch files with new paths and commit references |
tests/*.test.ts |
Improved test skip conditions and added better error handling |
packages/global/runtime/virtual-module.ts |
Added new properties for directive and resource insertion |
Multiple package.json files |
Updated Node.js types from version 20 to 22 |
Comments suppressed due to low confidence (1)
tests/node-websocket.test.ts:81
- The variable name NODE_ENV is ambiguous and doesn't clearly indicate it's storing the original value. Consider renaming to originalNodeEnv or previousNodeEnv for better clarity.
let NODE_ENV
No description provided.