Skip to content

chore: sync node-websocket to upstream #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 17, 2025
Merged

chore: sync node-websocket to upstream #149

merged 10 commits into from
Jul 17, 2025

Conversation

lilnasy
Copy link
Owner

@lilnasy lilnasy commented Jul 17, 2025

No description provided.

Copy link

changeset-bot bot commented Jul 17, 2025

🦋 Changeset detected

Latest commit: 2f3a7e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro-global Minor
astro-node-websocket Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lilnasy lilnasy marked this pull request as ready for review July 17, 2025 06:40
@lilnasy lilnasy requested a review from Copilot July 17, 2025 06:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR syncs the node-websocket package to the upstream Astro repository by updating the git submodule reference from withastro/adapters to withastro/astro and upgrading from @astrojs/[email protected] to @astrojs/[email protected]. Additionally, it includes improvements to WebSocket test conditions and adds new properties to the astro-global package.

Key Changes:

  • Updated git submodule from withastro/adapters to withastro/astro repository
  • Upgraded @astrojs/node version from 9.0.2 to 9.3.0
  • Improved WebSocket test conditions to check for WebSocket availability instead of Node.js version
  • Added new properties to astro-global package for directive and resource insertion

Reviewed Changes

Copilot reviewed 29 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.gitmodules Updated submodule path and URL to point to withastro/astro
packages/node-websocket/withastro/adapters Removed old submodule
packages/node-websocket/withastro/astro Added new submodule pointing to astro repository
packages/node-websocket/package.json Updated paths, dependencies, and scripts for new submodule structure
packages/node-websocket/*.patch Updated patch files with new paths and commit references
tests/*.test.ts Improved test skip conditions and added better error handling
packages/global/runtime/virtual-module.ts Added new properties for directive and resource insertion
Multiple package.json files Updated Node.js types from version 20 to 22
Comments suppressed due to low confidence (1)

tests/node-websocket.test.ts:81

  • The variable name NODE_ENV is ambiguous and doesn't clearly indicate it's storing the original value. Consider renaming to originalNodeEnv or previousNodeEnv for better clarity.
    let NODE_ENV

@lilnasy lilnasy merged commit 6b108f3 into main Jul 17, 2025
6 checks passed
@lilnasy lilnasy deleted the update-node branch July 17, 2025 06:45
@github-actions github-actions bot mentioned this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant