-
Notifications
You must be signed in to change notification settings - Fork 689
Unify file and dir names; integrate ls-lint #2476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
24bcd77
to
bd7c059
Compare
I always found it annoying that the links and the files don't match, in the "website" https://lima-vm.io/docs/examples/ -> |
I'm not sure about using snake_case for the So I would rather rename But in the end it is just personal preference. |
bd7c059
to
807029d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why factory-reset.go
was renamed to factory-reset_test.go
; it is not a test file.
That also breaks building the app:
undefined: newFactoryResetCommand
807029d
to
8f5561a
Compare
Signed-off-by: Oleksandr Redko <[email protected]>
8f5561a
to
35ccb6a
Compare
Renamed all directories to lowercase.
Changed.
Fixed. It's my fault. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Since this is largely based on personal preferences, I'll leave the merging to somebody else from @lima-vm/maintainers to give them a chance to object to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
The PR:
cmd
to matchkebab-case
for consistency;pkg/networks/usernet/UDPFileConn.go
topkg/networks/usernet/udpfileconn.go
website/content
to be lowercase;ls-lint
to ensure proper file and directory names in the future.