Unify Lima user home inside guest for all platforms#3378
Merged
AkihiroSuda merged 1 commit intolima-vm:masterfrom Apr 12, 2025
Merged
Unify Lima user home inside guest for all platforms#3378AkihiroSuda merged 1 commit intolima-vm:masterfrom
AkihiroSuda merged 1 commit intolima-vm:masterfrom
Conversation
Signed-off-by: Arthur Sengileyev <[email protected]>
3185091 to
b30505b
Compare
Contributor
Author
|
Ok, I see one problem with it now
So, it would always be Create a task for investigation of this. |
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the guest home directory across all platforms by removing Windows-specific handling for the guest home directory.
- Removed Windows-specific logic for transforming the guest home directory in pkg/osutil/user.go.
- Updated the test in pkg/limayaml/defaults_test.go to always set the home directory using a unified, Linux-style format.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/osutil/user.go | Removed Windows-specific home transformation to support a unified guest home path. |
| pkg/limayaml/defaults_test.go | Adjusted test to unconditionally apply the unified home directory format. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3364
I spent some time trying to understand if this code really makes sense. My conclusion is that it is probably the remains from the times, where the idea of mounting HOST home into GUEST home was explored. Since then there was a decision to have GUEST home separately, because it can be used for Lima GA needs. I could not think of any reason why GUEST home should be different from home directories on other platforms. This change remove all of the Windows specifics for GUEST home directory (keeping all other platform specific parts).
I tested this with integration tests using WSL2 and QEMU https://github.com/arixmkii/qcw/actions/runs/14022917109/job/39274813343