Add support for collecting instance IP address

[songponssw]

What does this PR do?

• Fix Report VM IP addresses to host agent #3616
• Adds support for generating an instance instance_info.json file.
• This file includes basic instance information: name, IPv4, and IPv6 addresses.

Implementation details

With GuestAgent:

• The raw output from ip -j a is embedded as json_bytes in the gRPC Events message.
• The GuestAgent listens for this event, extracts the IP information, and writes it to the instance_info.json file.

Without GuestAgent (Plain mode):

• This PR updates the executeSSH() function signature to return both the command output and error (instead of just error).
• After completing any requirements setup, HostAgent uses executeSSH() to run ip -j a, processes the output, and writes the instance info locally.

Testing

• Setup: Lima upstream master, OS(Ubuntu 22.02)
• templates: almalinux alpine debian fedora opensuse oraclelinux ubuntu
• Test command: limactl start INSTNAME --network lima:user-v2
• Result
  • With GuestAgent: All tests passed.
  • Plain Mode: Failed on AlmaLinux and Alpine — instances did not start successfully.

[AkihiroSuda]

Does this really work with busybox?

[jandubois]

It works with the Alpine cloud image from template://alpine. It does not work with alpine-lima from template://alpine-iso, but can easily be made to work by adding the iproute2 package to the image.

PS: I assume this question was about Alpine, and not busybox because the ip -j a would be executed in the guest and not in a container.

[afbjorklund]

I just used a shell script for apple container, since it "forgot" to update the /etc/hosts file.

echo "127.0.0.1 localhost" >/etc/hosts
echo "$(/sbin/ip -o -4 addr list eth0 | awk '{print $4}' | cut -d/ -f1) $(hostname)" >>/etc/hosts

[afbjorklund]

I thought that Alpine used ip from busybox by default, but maybe that is what you are saying above

[jandubois]

A minimal Alpine uses just busybox, but you can apk add iproute2 to install the real one. Our alpine-lima ISO image is the only one that is using busybox ip by default.

[songponssw]

Changes – Draft 2 (edited)

gRPC

• added CommandOutput message to hold output from the client.
• Created dedicated endpoints for GetIPv4 and GetIPv6.

Hostagent

• agent get ipaddress as the last step in host agent routine and it should all only when the instance spin up.
• Stores IP addresses internally
• Exports IP address through the Info strut in hostagent/api

CLI

• Added IPv4Address and IPv6Address fields
• IP address are now available, e.g.: limactl ls --format "{{ .Name }} {{ .IPv4Address }}"

Note;

• IPv6 is currently unavailable; no default route is found.
• gRPC compiled grpc with protoc-compiler 6.30.2

P.S. I'm trying my best to follow the design patterns found in the existing code. If there are any points that need refactoring, please let me know.