Fix: Pass SSHLocalPort as an option to configure driver
#3746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsuman
force-pushed
the
fix/rm-sshlocalport
branch
3 times, most recently
from
6a71b1b to
006b8ab
Compare
Signed-off-by: Ansuman Sahoo <[email protected]>
unsuman
force-pushed
the
fix/rm-sshlocalport
branch
from
006b8ab to
4ccf7d9
Compare
afbjorklund
requested changes
Jul 17, 2025
| // SetConfig sets the configuration for the instance. | ||
| Configure(inst *store.Instance, sshLocalPort int) *ConfiguredDriver | ||
| // Configure sets the configuration for the instance. | ||
| Configure(opts ...ConfigOption) *ConfiguredDriver |
There was a problem hiding this comment.
I think we want to keep the instance, since that will always be there.
Configure(inst *store.Instance, opts ...ConfigOption) *ConfiguredDriver
afbjorklund
reviewed
Jul 17, 2025
| @@ -41,8 +41,7 @@ message StartResponse { | |||
| } | |||
|
|
|||
| message SetConfigRequest { | |||
| bytes instance_config_json = 1; | |||
| int64 ssh_local_port = 3; | |||
| bytes config_opts = 1; | |||
There was a problem hiding this comment.
might have to decide on a transport here
afbjorklund
reviewed
Jul 17, 2025
| @@ -41,8 +41,7 @@ message StartResponse { | |||
| } | |||
|
|
|||
| message SetConfigRequest { | |||
| bytes instance_config_json = 1; | |||
There was a problem hiding this comment.
this one should remain, I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the configuration mechanism for drivers in the
pkg/driverpackage, replacing the previous method of passing individual parameters with a more flexible options-based approach. The changes introduce a newOptionsstruct andConfigOptiontype, enabling dynamic configuration and improving code maintainability and extensibility.Closes #3703