Release v2025-10-25 #278
Open
Release v2025-10-25 #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
- Resolve feature flags once in constructor to avoid env lookup per request - Validate optional viewer identifier with getLocalPart - Replace O(N) contact check with Set for O(1) lookup - Preserve original error stack using error cause - Use Object.assign for language/timezone merge - Minor optional chaining and nullish coalescing clean‑ups Signed-off-by: Pierre 'McFly' Marty <[email protected]>
- Fire matrix, directory and common‑settings queries concurrently using Promise.all. - Preserve original behaviour (early‑return when matrix data missing and additional features disabled). - Minor cleanup: use Object.assign for language/timezone merge and reuse the existing feature‑flag checks. Signed-off-by: Pierre 'McFly' Marty <[email protected]>
- Add four new tests covering:
* Missing Matrix profile with `additional_features` enabled (fallback to LDAP).
* Missing Matrix profile with `additional_features` disabled (returns null).
* Presence/absence of `language` and `timezone` based on the
`common_settings` feature flag.
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
- Extend integration tests to verify normal controller behavior. - Add unit tests that exercise additional branches: • get() returns 400 when auth userId is missing. • get() returns 403 when the service throws ForbiddenError. • updateVisibility() returns 403 when path userId differs from auth userId. • updateVisibility() returns 500 when service returns undefined. - Use lightweight request/response mocks to isolate controller logic. - Ensure mocks are reset before each test. Signed-off-by: Pierre 'McFly' Marty <[email protected]>
|
View your CI Pipeline Execution ↗ for commit 15bf0fa
☁️ Nx Cloud last updated this comment at |
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
Signed-off-by: Pierre 'McFly' Marty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.