Port to sable 4 #27

bastien-roucaries · 2025-08-06T07:21:03Z

Hi

To be tested after a merge on your vobject tree

Documentation does not work with trixie docker. Fix it. Add also some place to add local volume Signed-off-by: Bastien Roucariès <[email protected]>

Signed-off-by: Bastien Roucariès <[email protected]>

Will help testing Signed-off-by: Bastien Roucariès <[email protected]>

Signed-off-by: Bastien Roucariès <[email protected]>

Getting full stack in dev mode is a must to do Signed-off-by: Bastien Roucariès <[email protected]>

Signed-off-by: Bastien Roucariès <[email protected]>

According to documentation sender should not be null It will likely crash newer version of sabre Signed-off-by: Bastien Roucariès <[email protected]>

Signed-off-by: Bastien Roucariès <[email protected]>

- Switched to using WildcardEmitter (Sabre/Dav #896) - need _SERVER to be populated for test (sabre/http) Signed-off-by: Bastien Roucariès <[email protected]>

Signed-off-by: Bastien Roucariès <[email protected]>

chibenwa · 2025-08-19T02:55:44Z

Hello

I'm back from vacations and am delighted with this work. Thanks a lot for putting it together timely!

As explained in linagora/sabre-vobject#2 (comment) I encounter difficulties to access the https://github.com/bastien-roucaries/sabre-vobject repo => 404

While I have no issues with https://github.com/bastien-roucaries/esn-sabre

Is the visibility / access of the project set correctly?

As is it prevents me from pulling the code and test it locally...

Thanks!

bastien-roucaries · 2025-08-19T06:35:25Z

Le mardi 19 août 2025, 04:56:05 heure d’été d’Europe centrale Benoit TELLIER a écrit :

chibenwa left a comment (linagora/esn-sabre#27) Hello I'm back from vacations and am delighted with this work. Thanks a lot for putting it together timely! As explained in linagora/sabre-vobject#2 (comment) I encounter difficulties to access the https://github.com/bastien-roucaries/sabre-vobject repo => 404

https://github.com/bastien-roucaries/vobject Sorry for the typo

…

While I have no issues with https://github.com/bastien-roucaries/esn-sabre Is the visibility / access of the project set correctly? As is it prevents me from pulling the code and test it locally... Thanks!

chibenwa · 2025-08-19T17:30:28Z

Hello @bastien-roucaries

I did succeed to run integration tests atop this changeset using waiting-merges-4.2.2 branch of your vobject repository

It goes overall OK the IT tests (to be published : https://github.com/linagora/twake-calendar-integration-tests )

I uncovered the following issues (clear regressions):

User can no longer create events with external users. CalDavTest::inboxShouldContainInvites did fail creating an event with the following property:

 ATTENDEE;PARTSTAT=NEEDS-ACTION;RSVP=TRUE;ROLE=REQ-PARTICIPANT;CUTYPE=INDIVI
  DUAL;CN=Benoît TELLIER:mailto:[email protected]

And did yield the following log:

 sabre_dav 2025/08/19 17:04:10 [error] 14#14: *420 FastCGI sent in stderr: "PHP message: 3.7;Could not find principal for mailto:[email protected].
sabre_dav PHP message: 3.7;Could not find principal for mailto:[email protected]" while reading response header from upstream, client: 192.168.144.1, server: _, request: "PUT /calendars/68a4ae8a37fd7609fc1855bc/68a4ae8a37fd7609fc1855bc/abcd.ics HTTP/1.1", upstream: "fastcgi://unix:/var/run/php/php7.0-fpm.sock:", host: "192.168.144.6"

Looks like we can no longer invite external users...

On big issues HEAD on CardDAV did fail (CardDavTest::headShouldReturnFound) and returns a 500

sabre_dav [19-Aug-2025 16:57:43] WARNING: [pool www] child 24 said into stderr: "[2025-08-19 16:57:43] EsnSabre.CRITICAL: Uncaught exception {"exception":"[object] (Sabre\\VObject\\EofException(code: 0): End of document reached prematurely at /var/www/vendor/sabre/vobject/lib/Parser/MimeDir.php:284)"} []"

There are some minor issues that causes the tests to fail:

dtsamp is always rewitten (value mismatch & position) => test adaptations are needed
DAV: propfind always include an extra property: <d:propstat><d:prop><d:getlastmodified/><d:getcontentlength/><d:quota-used-bytes/><d:quota-available-bytes/><d:getetag/><d:getcontenttype/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat>. (naive question) Is it normal ?
Somehow we get mismatches on getetag are no longer ignored... => test adaptations are needed
sabre + vobject version changes => test adaptations are needed

FYI I created a task for some linagora employees to work on adapting the tests in order to lift these edge cases CF linagora/twake-calendar-integration-tests#1

bastien-roucaries · 2025-08-19T17:51:20Z

 User can no longer create events with external users. CalDavTest::inboxShouldContainInvites did fail creating an event with the following property:
ATTENDEE;PARTSTAT=NEEDS-ACTION;RSVP=TRUE;ROLE=REQ-PARTICIPANT;CUTYPE=INDIVI
DUAL;CN=Benoît TELLIER:mailto:[email protected]

And did yield the following log:

sabre_dav 2025/08/19 17:04:10 [error] 14#14: *420 FastCGI sent in stderr: "PHP message: 3.7;Could not find principal for mailto:[email protected].
sabre_dav PHP message: 3.7;Could not find principal for mailto:[email protected]" while reading response header from upstream, client: 192.168.144.1, server: _, request: "PUT /calendars/68a4ae8a37fd7609fc1855bc/68a4ae8a37fd7609fc1855bc/abcd.ics HTTP/1.1", upstream: "fastcgi://unix:/var/run/php/php7.0-fpm.sock:", host: "192.168.144.6"

Looks like we can no longer invite external users...

quickly check point to :
https://central.owncloud.org/t/dav-backend-error-when-providing-vcalendar-objects-inviting-seemingly-random-users-registered-on-the-owncloud-instance/31479/8

bastien-roucaries · 2025-08-19T19:20:29Z

sabre_dav [19-Aug-2025 16:57:43] WARNING: [pool www] child 24 said into stderr: "[2025-08-19 16:57:43] EsnSabre.CRITICAL: Uncaught exception {"exception":"[object] (Sabre\VObject\EofException(code: 0): End of document reached prematurely at /var/www/vendor/sabre/vobject/lib/Parser/MimeDir.php:284)"} []"

Could you check that in this case TZ is empty instead of being null ? BTW a full stack will help

bastien-roucaries · 2025-08-19T19:42:25Z

 User can no longer create events with external users. CalDavTest::inboxShouldContainInvites did fail creating an event with the following property:
ATTENDEE;PARTSTAT=NEEDS-ACTION;RSVP=TRUE;ROLE=REQ-PARTICIPANT;CUTYPE=INDIVI
DUAL;CN=Benoît TELLIER:mailto:[email protected]
And did yield the following log:
sabre_dav 2025/08/19 17:04:10 [error] 14#14: *420 FastCGI sent in stderr: "PHP message: 3.7;Could not find principal for mailto:[email protected].
sabre_dav PHP message: 3.7;Could not find principal for mailto:[email protected]" while reading response header from upstream, client: 192.168.144.1, server: _, request: "PUT /calendars/68a4ae8a37fd7609fc1855bc/68a4ae8a37fd7609fc1855bc/abcd.ics HTTP/1.1", upstream: "fastcgi://unix:/var/run/php/php7.0-fpm.sock:", host: "192.168.144.6"
Looks like we can no longer invite external users...
quickly check point to : https://central.owncloud.org/t/dav-backend-error-when-providing-vcalendar-objects-inviting-seemingly-random-users-registered-on-the-owncloud-instance/31479/8

For this one is likely a problem on non escaping somewhere the space in Benoit Telier somewhere. I full task and getting special char seens will likely help

bastien-roucaries · 2025-08-19T19:52:55Z

DAV: propfind always include an extra property: <d:propstat><d:prop><d:getlastmodified/><d:getcontentlength/><d:quota-used-bytes/><d:quota-available-bytes/><d:getetag/><d:getcontenttype/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat>. (naive question) Is it normal ?

I have no the full propfind output but according to RFC (note the MUST):

Each propstat XML element MUST contain a prop element that contains one or more properties, and a status element that contains a single HTTP status line. The propstat element MUST be used inside a response element to indicate the status of properties for a resource.”

Copilot

Pull Request Overview

This PR ports the project from Sabre DAV 3.x to Sabre DAV 4.x, updating dependencies and adapting code to work with the newer framework version.

Updates Sabre DAV from version 3.2.2 to 4.0.3 and vobject dependency
Adapts event listener registration patterns to use new Sabre 4 syntax
Updates test configurations and adds proper error handling with try/finally blocks

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
composer.json	Updates Sabre DAV and vobject dependencies to version 4.x
lib/JSON/Plugin.php	Changes event listener registration from 'beforeMethod' to 'beforeMethod:*'
lib/JSON/BasePlugin.php	Updates event listener registration pattern for Sabre 4 compatibility
lib/DAV/XHttpMethodOverridePlugin.php	Adapts event listener registration syntax
esn.php	Updates event listener and changes exception method call
lib/Utils/Utils.php	Adds proper try/finally block for error handling
tests/	Adds required sender/recipient properties and HTTP request parameters for test compatibility
scripts/generate_config.sh	Improves shell script quoting
config.tests.json	Updates configuration for Docker environment
compose-minimal.yml	Adds Docker Compose configuration for minimal testing setup
README.md	Updates documentation with new Docker setup instructions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

lib/DAV/XHttpMethodOverridePlugin.php

Copilot · 2025-10-10T09:51:28Z

esn.php

-    $server->on('beforeMethod', function() use ($e) {
-        throw new Sabre\DAV\Exception\ServiceUnavailable($e->getMessage());
+    $server->on('beforeMethod:*', function() use ($e) {
+        throw new Sabre\DAV\Exception\ServiceUnavailable($e->getTraceAsString());


Changed from getMessage() to getTraceAsString() which will expose full stack traces in error responses. This could leak sensitive information and should use getMessage() instead.

Suggested change

throw new Sabre\DAV\Exception\ServiceUnavailable($e->getTraceAsString());

throw new Sabre\DAV\Exception\ServiceUnavailable($e->getMessage());

compose-minimal.yml

README.md

chibenwa · 2025-10-10T14:16:13Z

Typos handled here

#92

bastien-roucaries added 14 commits August 4, 2025 13:40

Fix documentation

169af03

Documentation does not work with trixie docker. Fix it. Add also some place to add local volume Signed-off-by: Bastien Roucariès <[email protected]>

Quote output of json in order to get newline

103f201

Signed-off-by: Bastien Roucariès <[email protected]>

Fix style in order to get compilation work on docker

5bd84c7

Signed-off-by: Bastien Roucariès <[email protected]>

Add compose file

6d1f894

Will help testing Signed-off-by: Bastien Roucariès <[email protected]>

Use newer config.tests.json

06a3705

Signed-off-by: Bastien Roucariès <[email protected]>

Port to sabre-vobject 4.1.6

8e66749

Signed-off-by: Bastien Roucariès <[email protected]>

Port to 4.2.0

ccf0c43

Enable developper mode

20d230d

Signed-off-by: Bastien Roucariès <[email protected]>

Improve debugging

07ba6a8

Getting full stack in dev mode is a must to do Signed-off-by: Bastien Roucariès <[email protected]>

Add a little bit more space of rabbitmq

5aa13cb

Signed-off-by: Bastien Roucariès <[email protected]>

Message always need a sender

d3b94b2

According to documentation sender should not be null It will likely crash newer version of sabre Signed-off-by: Bastien Roucariès <[email protected]>

Fix a unsafe exception

0bb1dd4

Signed-off-by: Bastien Roucariès <[email protected]>

Update sabre

1a9d3d1

- Switched to using WildcardEmitter (Sabre/Dav #896) - need _SERVER to be populated for test (sabre/http) Signed-off-by: Bastien Roucariès <[email protected]>

Going back to linagora for vobject

97a34e5

Signed-off-by: Bastien Roucariès <[email protected]>

guimard assigned chibenwa Aug 6, 2025

chibenwa mentioned this pull request Aug 19, 2025

Adapt test suite to Sabre v4 linagora/twake-calendar-integration-tests#1

Closed

chibenwa mentioned this pull request Aug 22, 2025

CalDavTest::inboxShouldContainInvites with Sabre v4 #33

Closed

2 tasks

chibenwa added the sabre4 label Aug 22, 2025

chibenwa mentioned this pull request Aug 29, 2025

Port to Sabre 4 #41

Closed

chibenwa requested review from chibenwa and removed request for chibenwa August 29, 2025 06:25

chibenwa removed their assignment Aug 29, 2025

guimard requested a review from Copilot October 10, 2025 09:50

Copilot AI reviewed Oct 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Port to sable 4 #27

Port to sable 4 #27

bastien-roucaries commented Aug 6, 2025

Uh oh!

chibenwa commented Aug 19, 2025

Uh oh!

bastien-roucaries commented Aug 19, 2025 via email

Uh oh!

chibenwa commented Aug 19, 2025 •

edited

Loading

Uh oh!

bastien-roucaries commented Aug 19, 2025

Uh oh!

bastien-roucaries commented Aug 19, 2025

Uh oh!

bastien-roucaries commented Aug 19, 2025

Uh oh!

bastien-roucaries commented Aug 19, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Oct 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chibenwa commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	throw new Sabre\DAV\Exception\ServiceUnavailable($e->getTraceAsString());
	throw new Sabre\DAV\Exception\ServiceUnavailable($e->getMessage());

Port to sable 4 #27

Are you sure you want to change the base?

Port to sable 4 #27

Conversation

bastien-roucaries commented Aug 6, 2025

Uh oh!

chibenwa commented Aug 19, 2025

Uh oh!

bastien-roucaries commented Aug 19, 2025 via email

Uh oh!

chibenwa commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bastien-roucaries commented Aug 19, 2025

Uh oh!

bastien-roucaries commented Aug 19, 2025

Uh oh!

bastien-roucaries commented Aug 19, 2025

Uh oh!

bastien-roucaries commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chibenwa commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chibenwa commented Aug 19, 2025 •

edited

Loading

bastien-roucaries commented Aug 19, 2025 •

edited

Loading