ISSUE-405 Test domain address book: domain admin cannot share it to third party #103
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Oct 24, 2025
| .baseUri(tcalendarAdminApiBase) | ||
| .put("/domains/" + domainName + "/admins/" + bob.email()) | ||
| .then() | ||
| .statusCode(204); |
There was a problem hiding this comment.
Suggested change
| .statusCode(204); | |
| .statusCode(405); |
chibenwa
reviewed
Oct 24, 2025
There was a problem hiding this comment.
Please write the same tests also for domain-member addressbook.
Please refine the behaviours in particular:
- dab: update public right result in 405
- FAIL1 dab: update public right shall not be persisted
- dab: update sharee result in 405
- dab: update sharee is not persisted
While we are at it we shall also test domainMemberAddress book right management which shall fail:
- FAIL domain members -> result in 405 and not persisted for sharing and public right update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test normalUserCannotSetPublicRightOfDomainAddressBook and normalUserCannotDelegateDomainAddressBook, the returned http code is 403. Should it be 405?