TW-1781: upgrade Flutter tot 3.22 #1790

sherlockvn · 2024-05-21T18:43:10Z

Change apply:

remove background and onBackground color, now use only surface and onSurface
change name from surfaceVariant => surfaceContainerHighest, MaterialStateProperty => WidgetStateProperty, MaterialState => WidgetState, use super.key for shorter form (new lint rule)
Migration from RawKeyEvent to KeyEvent. Read more (in conclusion, add ignore_deprecated, because that when i test it again, the up/down not work)
Upgrade flutter_local_notification from requestPermission => requestNotificationsPermission Changelog, Readmore
Upgrade url_laucher, change from Uri to WebUri, remove ChromeSafariBrowserSettings in web
Upgrade the index.html file in web folder
Upgrade other packages in pubspec.yaml to resolve conflicts

Some note:

Web assembly can't be build yet(a lot of packages have not supported that), web assembly not support safari + firefox yet. But the web initialization is faster, i will update an video demo soon. Read more

Testing:

IOS:

RPReplay_Final1716361592.MP4

Android above 13 new notification permission:

Screen.Recording.2024-05-23.at.06.03.05.mov

Android under 13 :

Screen.Recording.2024-05-23.at.06.08.23.mov

Web chrome:

Screen.Recording.2024-05-23.at.09.45.11.mov

Web safari:

Screen.Recording.2024-05-23.at.09.53.54.mov

Web firefox:

Screen.Recording.2024-05-23.at.09.56.55.mov

github-actions · 2024-05-22T09:38:16Z

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1790

.github/workflows/gh-pages.yaml

.github/workflows/tests.yaml

hoangdat · 2024-05-24T02:53:22Z

android/app/src/main/AndroidManifest.xml

@@ -32,6 +32,7 @@
    <uses-permission android:name="android.permission.READ_MEDIA_VIDEO" />
    <uses-permission android:name="android.permission.READ_MEDIA_AUDIO" />
    <uses-permission android:name="android.permission.ACCESS_MEDIA_LOCATION" />
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>


please add adr

Demo this case, and compare with other application in case of Don't allow in android 13

Screen.Recording.2024-05-24.at.21.18.34.mov

lib/config/themes.dart

sherlockvn requested review from hoangdat, dab246, nqhhdev, hieutbui, tddang-linagora and Te-Z as code owners May 21, 2024 18:43

sherlockvn had a problem deploying to PR-1790 May 21, 2024 18:43 — with GitHub Actions Failure

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 69f73c0 to 832cd6c Compare May 22, 2024 06:37

sherlockvn had a problem deploying to PR-1790 May 22, 2024 06:37 — with GitHub Actions Failure

sherlockvn had a problem deploying to PR-1790 May 22, 2024 06:57 — with GitHub Actions Failure

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 832cd6c to 66cd62d Compare May 22, 2024 07:25

sherlockvn had a problem deploying to PR-1790 May 22, 2024 07:25 — with GitHub Actions Failure

sherlockvn had a problem deploying to PR-1790 May 22, 2024 08:10 — with GitHub Actions Failure

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 6ce5304 to 134386d Compare May 22, 2024 08:30

sherlockvn had a problem deploying to PR-1790 May 22, 2024 08:30 — with GitHub Actions Failure

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 134386d to ce76490 Compare May 22, 2024 09:20

sherlockvn had a problem deploying to PR-1790 May 22, 2024 09:20 — with GitHub Actions Failure

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from ce76490 to 07adff0 Compare May 22, 2024 09:27

sherlockvn temporarily deployed to PR-1790 May 22, 2024 09:27 — with GitHub Actions Inactive

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 07adff0 to 761aa6b Compare May 23, 2024 01:35

sherlockvn temporarily deployed to PR-1790 May 23, 2024 01:35 — with GitHub Actions Inactive

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 761aa6b to b2fa8a2 Compare May 23, 2024 08:48

sherlockvn temporarily deployed to PR-1790 May 23, 2024 08:49 — with GitHub Actions Inactive

hoangdat reviewed May 24, 2024

View reviewed changes

.github/workflows/gh-pages.yaml Outdated Show resolved Hide resolved

hoangdat reviewed May 24, 2024

View reviewed changes

.github/workflows/tests.yaml Outdated Show resolved Hide resolved

hoangdat reviewed May 24, 2024

View reviewed changes

lib/config/themes.dart Outdated Show resolved Hide resolved

sherlockvn had a problem deploying to PR-1790 May 24, 2024 05:20 — with GitHub Actions Failure

sherlockvn had a problem deploying to PR-1790 May 24, 2024 05:56 — with GitHub Actions Failure

hoangdat had a problem deploying to prod May 25, 2024 07:04 — with GitHub Actions Failure

hoangdat temporarily deployed to prod May 25, 2024 07:04 — with GitHub Actions Inactive

hoangdat had a problem deploying to prod May 25, 2024 07:04 — with GitHub Actions Failure

hoangdat temporarily deployed to prod May 25, 2024 07:04 — with GitHub Actions Inactive

hoangdat had a problem deploying to prod May 25, 2024 07:05 — with GitHub Actions Failure

hoangdat force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 782a2d8 to b531698 Compare May 25, 2024 07:26

hoangdat temporarily deployed to PR-1790 May 25, 2024 07:26 — with GitHub Actions Inactive

hoangdat temporarily deployed to prod May 25, 2024 07:36 — with GitHub Actions Inactive

hoangdat had a problem deploying to prod May 25, 2024 07:36 — with GitHub Actions Failure

hoangdat temporarily deployed to prod May 25, 2024 07:36 — with GitHub Actions Inactive

hoangdat force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from b531698 to 113b8c5 Compare May 25, 2024 07:58

hoangdat temporarily deployed to PR-1790 May 25, 2024 07:58 — with GitHub Actions Inactive

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 113b8c5 to 839e530 Compare May 25, 2024 08:08

sherlockvn temporarily deployed to PR-1790 May 25, 2024 08:08 — with GitHub Actions Inactive

hoangdat force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 839e530 to 113b8c5 Compare May 25, 2024 08:10

hoangdat had a problem deploying to PR-1790 May 25, 2024 08:10 — with GitHub Actions Error

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from 113b8c5 to a1f8905 Compare May 25, 2024 08:12

sherlockvn temporarily deployed to PR-1790 May 25, 2024 08:12 — with GitHub Actions Inactive

TW-1781 Fix ci failed

a933579

sherlockvn force-pushed the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch from a1f8905 to a933579 Compare May 25, 2024 08:50

sherlockvn deployed to PR-1790 May 25, 2024 08:50 — with GitHub Actions View deployment

hoangdat approved these changes May 25, 2024

View reviewed changes

hoangdat merged commit 9790230 into main May 25, 2024
12 checks passed

hoangdat deleted the upgrade_3_22/part-I-update-version-of-packages-in-pubspec branch May 25, 2024 10:00

sherlockvn changed the title ~~TW-1781: upgrade package inside the pubspec to compatibality with flu…~~ TW-1781: upgrade package inside the pubspec to compatibality with flutter Jul 1, 2024

sherlockvn changed the title ~~TW-1781: upgrade package inside the pubspec to compatibality with flutter~~ TW-1781: upgrade Flutter tot 3.22 Jul 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TW-1781: upgrade Flutter tot 3.22 #1790

TW-1781: upgrade Flutter tot 3.22 #1790

sherlockvn commented May 21, 2024 •

edited

Loading

github-actions bot commented May 22, 2024

hoangdat May 24, 2024

hoangdat May 24, 2024

sherlockvn May 24, 2024

TW-1781: upgrade Flutter tot 3.22 #1790

TW-1781: upgrade Flutter tot 3.22 #1790

Conversation

sherlockvn commented May 21, 2024 • edited Loading

Change apply:

Some note:

Testing:

IOS:

Android above 13 new notification permission:

Android under 13 :

Web chrome:

Web safari:

Web firefox:

github-actions bot commented May 22, 2024

hoangdat May 24, 2024

Choose a reason for hiding this comment

hoangdat May 24, 2024

Choose a reason for hiding this comment

sherlockvn May 24, 2024

Choose a reason for hiding this comment

sherlockvn commented May 21, 2024 •

edited

Loading