-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-2114: Display phone number as a clickable in message bubble #2120
Open
nqhhdev
wants to merge
5
commits into
main
Choose a base branch
from
TW-2114-display-phone-number-as-a-clickable-in-message-bubble
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TW-2114: Display phone number as a clickable in message bubble #2120
nqhhdev
wants to merge
5
commits into
main
from
TW-2114-display-phone-number-as-a-clickable-in-message-bubble
+278
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
sherlockvn,
hoangdat,
dab246,
hieutbui and
tddang-linagora
as code owners
November 4, 2024 11:59
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2120 |
hoangdat
reviewed
Nov 8, 2024
@@ -8,7 +8,8 @@ enum ChatContextMenuActions { | |||
pinChat, | |||
forward, | |||
downloadFile, | |||
jumpToMessage; | |||
jumpToMessage, | |||
copyNumber; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should create PhoneNumberContextMenu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Need merge
Attach screenshots or videos demonstrating the changes