Skip to content

Add ruff check for all PR without changing the content #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025
Merged

Conversation

calvinchai
Copy link
Contributor

No description provided.

@calvinchai
Copy link
Contributor Author

currently Ruff will only run when commits are merged and it will create a commit with automatic fix. This added pipeline will run for all PR before they are merged and fail if the requested changing files are not compliant.

@calvinchai calvinchai requested review from kabilar and balbasty July 21, 2025 20:36
@balbasty
Copy link
Collaborator

I don't know much about Ruff actions. Do you need content: write if you only run checks without changing files?

@calvinchai
Copy link
Contributor Author

I don't know much about Ruff actions. Do you need content: write if you only run checks without changing files?

nope. i am going to remove that

@balbasty balbasty merged commit 4ecb4c9 into main Jul 29, 2025
9 of 10 checks passed
@calvinchai calvinchai deleted the ruffcheck branch July 31, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants