Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pack_lists class function #136

Merged
merged 5 commits into from
Aug 19, 2024
Merged

add pack_lists class function #136

merged 5 commits into from
Aug 19, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Aug 13, 2024

Change Description

Resolves #131

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

github-actions bot commented Aug 13, 2024

Before [975fbc8] After [2d12de8] Ratio Benchmark (Parameter)
34.2±3ms 35.8±1ms 1.05 benchmarks.AssignSingleDfToNestedSeries.time_run
10.4±0.2ms 10.7±0.3ms 1.03 benchmarks.NestedFrameAddNested.time_run
7.02±0.2ms 7.11±0.2ms 1.01 benchmarks.NestedFrameQuery.time_run
87.1M 87M 1 benchmarks.NestedFrameAddNested.peakmem_run
92M 92.3M 1 benchmarks.NestedFrameQuery.peakmem_run
90.8M 90.7M 1 benchmarks.NestedFrameReduce.peakmem_run
260M 258M 0.99 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
1.14±0.03ms 1.11±0.02ms 0.97 benchmarks.NestedFrameReduce.time_run
281M 272M 0.97 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
75.5±5ms 72.0±3ms 0.95 benchmarks.ReassignHalfOfNestedSeries.time_run

Click here to view all benchmarks.

@dougbrn dougbrn marked this pull request as ready for review August 13, 2024 20:58
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (975fbc8) to head (b087283).
Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   99.45%   99.46%           
=======================================
  Files          14       14           
  Lines         917      932   +15     
=======================================
+ Hits          912      927   +15     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn requested a review from wilsonbb August 13, 2024 21:12
Copy link
Contributor

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me just a few small test cases I think it would be nice to add

(Sorry I thought I had reviewed this earlier in the week, but it seemed to have slipped by)

@dougbrn dougbrn requested a review from wilsonbb August 19, 2024 18:44
Copy link
Contributor

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougbrn dougbrn merged commit 6e2f433 into main Aug 19, 2024
11 checks passed
@dougbrn dougbrn deleted the from_lists branch August 19, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a shorthand from_lists NestedFrame generator function
2 participants