Checking 214e5d5c0ec6a2d5e0d16e35fd9e8e1d3572d246 #18
Annotations
1 error and 25 warnings
rustfmt
Process completed with exit code 1.
|
rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy@master. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy:
src/lib.rs#L7
warning: this import is redundant
--> src/lib.rs:7:1
|
7 | use serde_json;
| ^^^^^^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `#[warn(clippy::single_component_path_imports)]` on by default
|
Clippy:
src/lib.rs#L7
warning: this import is redundant
--> src/lib.rs:7:1
|
7 | use serde_json;
| ^^^^^^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `#[warn(clippy::single_component_path_imports)]` on by default
|
Clippy:
src/lib.rs#L15
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lib.rs:15:52
|
15 | if family == "emojis" && !is_emoji(str_to_char(&id)) {
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
Clippy:
src/lib.rs#L15
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lib.rs:15:52
|
15 | if family == "emojis" && !is_emoji(str_to_char(&id)) {
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
Clippy:
src/lib.rs#L129
warning: called `map(..).flatten()` on `Iterator`
--> src/lib.rs:129:48
|
129 | let shortcodes: Vec<&str> = emojis::iter().map(|x| x.shortcodes()).flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.shortcodes())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
|
Clippy:
src/lib.rs#L151
warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
--> src/lib.rs:151:5
|
151 | s.chars().nth(0).unwrap()
| ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `s.chars().next()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
= note: `#[warn(clippy::iter_nth_zero)]` on by default
|
Clippy:
src/lib.rs#L129
warning: called `map(..).flatten()` on `Iterator`
--> src/lib.rs:129:48
|
129 | let shortcodes: Vec<&str> = emojis::iter().map(|x| x.shortcodes()).flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.shortcodes())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
|
Clippy:
src/lib.rs#L151
warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
--> src/lib.rs:151:5
|
151 | s.chars().nth(0).unwrap()
| ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `s.chars().next()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
= note: `#[warn(clippy::iter_nth_zero)]` on by default
|
Clippy:
src/main.rs#L19
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> src/main.rs:19:44
|
19 | .expect("TODO: Fix this mess.")
| ____________________________________________^
20 | | .to_string()
| |________________________^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
Clippy:
src/main.rs#L19
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> src/main.rs:19:44
|
19 | .expect("TODO: Fix this mess.")
| ____________________________________________^
20 | | .to_string()
| |________________________^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
cargo-test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|