Make SAML relayState max length configurable #6381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default `SsoHandler` currently omits `relayState` when its length exceeds 80 characters. Although the SAML spec defines an 80-character limit, many implementations do not strictly enforce it, and this restriction is often too tight in practice. References: - https://docs.oasis-open.org/security/saml/v2.0/saml-bindings-2.0-os.pdf - https://help.salesforce.com/s/articleView?id=000387925&type=1 Modifications: - Introduced `SamlServiceProviderBuilder.relayStateMaxLength()` to configure the maximum length. Result: - You can override the default 80-character restriction for SAML relayState.
minwoox
commented
Sep 2, 2025
| // The value MUST NOT exceed 80 bytes in length and SHOULD be integrity protected by the entity | ||
| // creating the message independent of any other protections that may or may not exist | ||
| // during message transmission. | ||
| if (relayState.length() > 80) { |
Contributor
Author
There was a problem hiding this comment.
We don't need to check the relayState length here because it's not set in the default SsoHandler if it exceeds 80 characters, so let me just remove this condition.
Additionally, we were not checking this limit in the post binding, even though the Spec says it should.
Contributor
jrhee17
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The default
SsoHandlercurrently omitsrelayStatewhen its length exceeds 80 characters. Although the SAML spec defines an 80-character limit, many implementations do not strictly enforce it, and this restriction is often too tight in practice.References:
Modifications:
SamlServiceProviderBuilder.relayStateMaxLength()to configure the maximum length.Result: