-
Notifications
You must be signed in to change notification settings - Fork 967
Migrate to JSpecify annotations #6456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sh-cho
wants to merge
7
commits into
line:main
Choose a base branch
from
sh-cho:jspecify-nullable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🔍 Build Scan® (commit: a03482b) |
Contributor
Author
|
Need to sort out commits |
Signed-off-by: Seonghyeon Cho <[email protected]>
Signed-off-by: Seonghyeon Cho <[email protected]>
Signed-off-by: Seonghyeon Cho <[email protected]>
65442a8 to
a329f31
Compare
Signed-off-by: Seonghyeon Cho <[email protected]>
a329f31 to
b4e359d
Compare
Signed-off-by: Seonghyeon Cho <[email protected]> Remove temp comment Signed-off-by: Seonghyeon Cho <[email protected]> Add deprecated comment Signed-off-by: Seonghyeon Cho <[email protected]> Add indent on imports Signed-off-by: Seonghyeon Cho <[email protected]> Add indent more Signed-off-by: Seonghyeon Cho <[email protected]>
Signed-off-by: Seonghyeon Cho <[email protected]>
`Type argument is not within its bounds: should be subtype of 'kotlin.Any'.`, etc Signed-off-by: Seonghyeon Cho <[email protected]>
b4e359d to
a03482b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
I'll open this after #6457 gets merged and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Base: #6457)
Motivation:
jsr-305 is dormant and now JSpecify is recommended annotation sets for variety of static analyses (for now, it supports only nullness) and many open sources are moving to JSpecify (e.g. Spring Framework, Guava, ...)
Modifications:
com.linecorp.armeria.common.annotation.Nullable->org.jspecify.annotations.NullMarkedcom.linecorp.armeria.common.annotation.NonNullByDefault->org.jspecify.annotations.NullableNote:
Since JSpecify's Nullable annotation is type-use annotation, placement of existing jsr-305 annotations are incompatible with JSpecify one, so following steps should be applied (ref: https://jspecify.dev/docs/using/#if-your-code-already-uses-jsr-305-annotations)
@Nullable Object[]->Object @Nullable []@Nullable Map.Entry<K, V>->Map.@Nullable Entry<K, V>Result: