Skip to content

Conversation

@jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Oct 27, 2025

Motivation:

Explain why you're making this change and what problem you're trying to solve.

Modifications:

  • List the modifications you've made in detail.

Result:

  • Closes #. (If this resolves the issue.)
  • Describe the consequences that a user will face after this PR is merged.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 80.16878% with 94 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.24%. Comparing base (8150425) to head (bf502d3).
⚠️ Report is 226 commits behind head on main.

Files with missing lines Patch % Lines
.../com/linecorp/armeria/xds/XdsBootstrapBuilder.java 16.66% 20 Missing ⚠️
...a/internal/client/DefaultClientRequestContext.java 52.63% 3 Missing and 6 partials ⚠️
...a/xds/DefaultXdsLoadBalancerLifecycleObserver.java 94.37% 6 Missing and 3 partials ⚠️
...ain/java/com/linecorp/armeria/xds/StatContext.java 0.00% 7 Missing ⚠️
.../com/linecorp/armeria/xds/ClusterResourceNode.java 45.45% 5 Missing and 1 partial ⚠️
...ain/java/com/linecorp/armeria/xds/WatcherUtil.java 0.00% 6 Missing ⚠️
...com/linecorp/armeria/xds/AbstractResourceNode.java 66.66% 5 Missing ⚠️
...eria/xds/DefaultConfigSourceLifecycleObserver.java 91.93% 3 Missing and 2 partials ⚠️
...com/linecorp/armeria/xds/ListenerResourceNode.java 54.54% 5 Missing ⚠️
.../linecorp/armeria/xds/ResourceNodeMeterBinder.java 82.14% 5 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6464      +/-   ##
============================================
- Coverage     74.46%   74.24%   -0.22%     
- Complexity    22234    23089     +855     
============================================
  Files          1963     2071     +108     
  Lines         82437    86623    +4186     
  Branches      10764    11319     +555     
============================================
+ Hits          61385    64316    +2931     
- Misses        15918    16905     +987     
- Partials       5134     5402     +268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrhee17 jrhee17 force-pushed the feat/xds-error branch 2 times, most recently from e8aea8d to 39afc56 Compare November 11, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant